Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_eventhub_namespace: fix downgrade scenario #10536

Merged
merged 2 commits into from
Feb 11, 2021
Merged

azurerm_eventhub_namespace: fix downgrade scenario #10536

merged 2 commits into from
Feb 11, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #10244.

In a corner case when we are downgrading from Standard to Basic SKU and namespace had both autoInflate enabled and
maximumThroughputUnits set - we need to force throughput units back to 0, otherwise downgrade fails

$ TF_ACC=1 go test -v ./azurerm/internal/services/eventhub -timeout=1000m -run=TestAccEventHubNamespace_TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput -run=TestAccEventHubNamespace_basicWithIdentity
=== RUN   TestAccEventHubNamespace_basicWithIdentity
=== PAUSE TestAccEventHubNamespace_basicWithIdentity
=== CONT  TestAccEventHubNamespace_basicWithIdentity
--- PASS: TestAccEventHubNamespace_basicWithIdentity (269.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub	270.272s
$ TF_ACC=1 go test -v ./azurerm/internal/services/eventhub -timeout=1000m -run=TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput
=== RUN   TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput
=== PAUSE TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput
=== CONT  TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput
--- PASS: TestAccEventHubNamespace_SkuDowngradeFromAutoInflateWithMaxThroughput (678.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub	679.681s

@ghost ghost added the size/S label Feb 11, 2021
katbyte
katbyte approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte added this to the v2.47.0 milestone Feb 11, 2021
@katbyte katbyte merged commit bca10e5 into hashicorp:master Feb 11, 2021
katbyte added a commit that referenced this pull request Feb 11, 2021
@katbyte
CHANGELOG.md for #10536
946acb9
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/event-hubs EventHubs size/S
Projects
None yet
Milestone
v2.47.0
Development

Successfully merging this pull request may close these issues.

Cannot change azurerm_eventhub_namespace from Standard to Basic due to auto-scale
2 participants
@favoretti @katbyte